Ozone: HDC should only keep track of planes owned by it’s crtc controllers

ui/ozone/platform/drm/gpu/hardware_display_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/drm/gpu/hardware_display_controller.h"
 
 #include <drm.h>
 #include <string.h>
 #include <xf86drm.h>
 
@@ skipping 24 matching lines @@
 HardwareDisplayController::~HardwareDisplayController() {
   // Reset the cursor.
   UnsetCursor();
 }
 
 bool HardwareDisplayController::Modeset(const OverlayPlane& primary,
                                         drmModeModeInfo mode) {
   TRACE_EVENT0("drm", "HDC::Modeset");
   DCHECK(primary.buffer.get());
   bool status = true;
-  for (size_t i = 0; i < crtc_controllers_.size(); ++i)
-    status &= crtc_controllers_[i]->Modeset(primary, mode);
+
+  scoped_refptr<DrmDevice> drm = GetAllocationDrmDevice();
+  HardwareDisplayPlaneList* plane_list = owned_hardware_planes_.get(drm.get());
+  // CRTC controllers owned by this HDC might have changed, refresh the list.

[dnicoara, 2015/08/18 17:07:52]

Since the RemoveCrtc() all updates the list for the old HDC, couldn't you add
the planes for new controllers in AddCrtc()?

[kalyank, 2015/08/18 23:15:40]

Done.

+  plane_list->old_plane_list.clear();
+
+  HardwareDisplayPlaneManager* manager = drm->plane_manager();
+  const ScopedVector<HardwareDisplayPlane>& all_planes = manager->planes();
+  for (auto* controller : crtc_controllers_) {
+    status &= controller->Modeset(primary, mode);
+    uint32_t crtc = controller->crtc();
+    for (auto* plane : all_planes) {
+      if (plane->in_use() && (plane->owning_crtc() == crtc))
+        plane_list->old_plane_list.push_back(plane);
+    }
+  }
 
   is_disabled_ = false;
   mode_ = mode;
 
   return status;
 }
 
 void HardwareDisplayController::Disable() {
   TRACE_EVENT0("drm", "HDC::Disable");
   for (size_t i = 0; i < crtc_controllers_.size(); ++i)
@@ skipping 99 matching lines @@
       // Remove entry from |owned_hardware_planes_| iff no other crtcs share it.
       bool found = false;
       for (ScopedVector<CrtcController>::iterator it =
                crtc_controllers_.begin();
            it != crtc_controllers_.end(); ++it) {
         if ((*it)->drm() == controller->drm()) {
           found = true;
           break;
         }
       }
-      if (!found)
+      if (found) {
+        std::vector<HardwareDisplayPlane*> all_planes;
+        HardwareDisplayPlaneList* plane_list =
+            owned_hardware_planes_.get(drm.get());
+        all_planes.swap(plane_list->old_plane_list);
+        for (auto* plane : all_planes) {
+          if (plane->owning_crtc() != crtc)
+            plane_list->old_plane_list.push_back(plane);
+        }
+      } else {
         owned_hardware_planes_.erase(controller->drm().get());
+      }
 
       return controller.Pass();
     }
   }
 
   return nullptr;
 }
 
 bool HardwareDisplayController::HasCrtc(const scoped_refptr<DrmDevice>& drm,
                                         uint32_t crtc) const {
@@ skipping 28 matching lines @@
 
 scoped_refptr<DrmDevice> HardwareDisplayController::GetAllocationDrmDevice()
     const {
   DCHECK(!crtc_controllers_.empty());
   // TODO(dnicoara) When we support mirroring across DRM devices, figure out
   // which device should be used for allocations.
   return crtc_controllers_[0]->drm();
 }
 
 }  // namespace ui