service/datastore/reflect.go - Issue 1279703003: Get rid of awkward proto argument to Interface.Run

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/reflect.go

Issue 1279703003: Get rid of awkward proto argument to Interface.Run (Closed) Base URL: https://github.com/luci/gae.git@master

Patch Set: In/Out return Type not interface{} Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/datastore/reflect.go

diff --git a/service/datastore/reflect.go b/service/datastore/reflect.go

index a2d30c70f8aded02b8c2a24035d0b08ef22a1fed..16fc67e02ebc5348249a463e9d7e252fb0fbf814 100644

--- a/service/datastore/reflect.go

+++ b/service/datastore/reflect.go

@@ -12,8 +12,10 @@ import (

)

var (

+ typeOfBool = reflect.TypeOf(true)

typeOfBSKey = reflect.TypeOf(blobstore.Key(""))

typeOfByteString = reflect.TypeOf(ByteString(nil))

+ typeOfCursorCB = reflect.TypeOf(CursorCB(nil))

typeOfGeoPoint = reflect.TypeOf(GeoPoint{})

typeOfInt64 = reflect.TypeOf(int64(0))

typeOfKey = reflect.TypeOf((*Key)(nil)).Elem()