service/datastore/checkfilter_test.go - Issue 1279703003: Get rid of awkward proto argument to Interface.Run

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/checkfilter_test.go

Issue 1279703003: Get rid of awkward proto argument to Interface.Run (Closed) Base URL: https://github.com/luci/gae.git@master

Patch Set: In/Out return Type not interface{} Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/datastore/checkfilter_test.go

diff --git a/service/datastore/checkfilter_test.go b/service/datastore/checkfilter_test.go

index f118d57658c130c9d45199739fd8038712dd3053..445b9d0aec03e0c7dc6bf5361fe1cc4a27d2a6f9 100644

--- a/service/datastore/checkfilter_test.go

+++ b/service/datastore/checkfilter_test.go

@@ -49,7 +49,7 @@ func TestCheckFilter(t *testing.T) {

So(rds.Run(rds.NewQuery("sup"), nil).Error(), ShouldContainSubstring, "callback is nil")

hit := false

So(func() {

- rds.Run(rds.NewQuery("sup"), func(Key, PropertyMap, func() (Cursor, error)) bool {

+ rds.Run(rds.NewQuery("sup"), func(Key, PropertyMap, CursorCB) bool {

hit = true

return true

})

« no previous file with comments | « no previous file | service/datastore/datastore.go » ('j') | service/datastore/datastore.go » ('J')