Issue 12797016: Merge 144642 "Don't apply page scale to clipRect if applyPageSca..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12797016: Merge 144642 "Don't apply page scale to clipRect if applyPageSca..." (Closed)

Created:
7 years, 9 months ago by Xianzhu

Modified:
7 years, 9 months ago

Reviewers:
Xianzhu

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/

Visibility:
Public.

More Reviews

Description

Merge 144642 "Don't apply page scale to clipRect if applyPageSca..." > Don't apply page scale to clipRect if applyPageScaleFactorInCompositor is set to true > https://bugs.webkit.org/show_bug.cgi?id=111229 > > Patch by Min Qin <qinmin@chromium.org>; on 2013-03-04 > Reviewed by Simon Fraser. > > If applyPageScaleFactorInCompositor is set to true, webcore should use css coordinates. > As a result, we shouldn't apply page scale to clipRect in RenderLayerCompositor. > Layout tests set the flag to false, so we don't have anything to test against. > > * rendering/RenderLayerCompositor.cpp: > (WebCore::RenderLayerCompositor::addToOverlapMap): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146648

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	Source/WebCore/rendering/RenderLayerCompositor.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r146648.

Expand Messages | Collapse Messages