Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 127963004: Removal of GetDefaultProfile from UserManagerImpl (Closed)

Created:
6 years, 11 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Removal of GetDefaultProfile from UserManagerImpl BUG=322682 TEST=covered by existing unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243860

Patch Set 1 #

Patch Set 2 : self nit - comment #

Patch Set 3 : The replacement was causing a recursion in some cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Mr4D (OOO till 08-26)
Aaaand another one - please have a look!
6 years, 11 months ago (2014-01-08 16:43:26 UTC) #1
Dmitry Polukhin
lgtm
6 years, 11 months ago (2014-01-08 16:44:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/127963004/40001
6 years, 11 months ago (2014-01-08 17:02:21 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=189345
6 years, 11 months ago (2014-01-08 18:12:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/127963004/40001
6 years, 11 months ago (2014-01-08 18:23:55 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=189398
6 years, 11 months ago (2014-01-08 20:22:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/127963004/40001
6 years, 11 months ago (2014-01-08 20:36:02 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=189462
6 years, 11 months ago (2014-01-08 22:04:37 UTC) #8
Mr4D (OOO till 08-26)
+rlp could you please do an owners review?
6 years, 11 months ago (2014-01-08 23:53:10 UTC) #9
rpetterson
lgtm
6 years, 11 months ago (2014-01-09 01:22:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/127963004/520001
6 years, 11 months ago (2014-01-09 02:06:04 UTC) #11
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 12:13:08 UTC) #12
Message was sent while issue was closed. 
Change committed as 243860

Powered by Google App Engine
This is Rietveld 408576698