Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1279613008: Revert of Debugger: clear shared function info list when recompiling for liveedit. (Closed)

Created:
5 years, 4 months ago by vogelheim
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Debugger: clear shared function info list when recompiling for liveedit. (patchset #1 id:1 of https://codereview.chromium.org/1270313003/ ) Reason for revert: Sorry for revert, but this change breaks one of the webkit-unit-tests. Example here: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/1178/layout-test-results/inspector/sources/debugger/live-edit-no-reveal-diff.txt Not sure if the old expectations were right, or the new ones are. :) Original issue's description: > Debugger: clear shared function info list when recompiling for liveedit. > > R=bmeurer@chromium.org > BUG=chromium:517594 > LOG=N > > Committed: https://crrev.com/9eea3ef5147a5e15256093fb4c36a7598d60d128 > Cr-Commit-Position: refs/heads/master@{#30111} TBR=bmeurer@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:517594 Committed: https://crrev.com/aa97b065059b26eb3abe28ea56b2978a621e1585 Cr-Commit-Position: refs/heads/master@{#30112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
vogelheim
Created Revert of Debugger: clear shared function info list when recompiling for liveedit.
5 years, 4 months ago (2015-08-11 13:55:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279613008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279613008/1
5 years, 4 months ago (2015-08-11 13:56:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 13:56:22 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 13:56:39 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa97b065059b26eb3abe28ea56b2978a621e1585
Cr-Commit-Position: refs/heads/master@{#30112}

Powered by Google App Engine
This is Rietveld 408576698