Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 12796004: [Android] Use generated JNI bindings for Download Controller (Closed)

Created:
7 years, 9 months ago by Yaron
Modified:
7 years, 9 months ago
Reviewers:
nilesh
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[Android] Use generated JNI bindings for Download Controller We're removing the often error-prone manual bindings with the JNI generator. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187719

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -25 lines) Patch
M content/browser/android/download_controller_android_impl.cc View 6 chunks +7 lines, -23 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/DownloadController.java View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yaron
7 years, 9 months ago (2013-03-12 21:09:58 UTC) #1
Agrawal
On 2013/03/12 21:09:58, Yaron wrote: LGTM
7 years, 9 months ago (2013-03-12 21:20:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/12796004/1
7 years, 9 months ago (2013-03-13 00:32:10 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-13 00:37:03 UTC) #4
Message was sent while issue was closed.
Change committed as 187719

Powered by Google App Engine
This is Rietveld 408576698