Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1619)

Unified Diff: chrome/browser/net/chrome_network_delegate.cc

Issue 1279543002: Support needed to measure user and service traffic in Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NewHistogram
Patch Set: Addressing reviewers' comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/chrome_network_delegate.cc
diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc
index bed47f796f2a1f8d21426ade117ada47c08e8877..b62274e15fee87c23aef5e0bca1b0e6fecc72fb5 100644
--- a/chrome/browser/net/chrome_network_delegate.cc
+++ b/chrome/browser/net/chrome_network_delegate.cc
@@ -491,6 +491,13 @@ void ChromeNetworkDelegate::OnNetworkBytesReceived(
void ChromeNetworkDelegate::OnCompleted(net::URLRequest* request,
bool started) {
+#if !defined(OS_IOS)
+ // TODO(amohammadkhan): Reporting should be done on redirects too. Because
+ // following a redirect resets the received/sent bytes. Though if the request
+ // is cancelled instead of following the redirect, it will end up here, and
+ // the data will be double counted.
+ data_use_measurement_.ReportDataUseUMA(request);
mmenke 2015/09/03 16:02:58 Think first pass, you should measure usage for red
amohammadkhan 2015/09/03 23:10:36 Sorry I think I didn't understand what you meant f
+#endif
RecordNetworkErrorHistograms(request);
if (started) {
// Only call in for requests that were started, to obey the precondition

Powered by Google App Engine
This is Rietveld 408576698