chrome/browser/profiles/profile_manager.cc - Issue 1279543002: Support needed to measure user and service traffic in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_manager.cc

Issue 1279543002: Support needed to measure user and service traffic in Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NewHistogram

Patch Set: Adding sclittle to OWNERs and little fix in ChromeNetworkDelegate test. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/chrome_network_delegate_unittest.cc ('K') | « chrome/browser/net/chrome_network_delegate_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | components/data_use_measurement/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_manager.cc

diff --git a/chrome/browser/profiles/profile_manager.cc b/chrome/browser/profiles/profile_manager.cc

index 67acac17bb9292879caed2b9e2b9722271896fc3..c0f2239f80cb0742478d5b1a64c4b26fda7ea36d 100644

--- a/chrome/browser/profiles/profile_manager.cc

+++ b/chrome/browser/profiles/profile_manager.cc

@@ -459,6 +459,9 @@ void ProfileManager::CreateProfileAsync(

}

bool ProfileManager::IsValidProfile(Profile* profile) {

+ ProfileManager* pm = g_browser_process->profile_manager();

Alexei Svitkine (slow) 2015/08/31 17:26:31 Nit: Just inline this into the if, if you're only

amohammadkhan 2015/09/01 04:52:48 Done.

+ if (!pm) // Is NULL when running unit tests.

+ return false;

for (ProfilesInfoMap::iterator iter = profiles_info_.begin();

iter != profiles_info_.end(); ++iter) {

if (iter->second->created) {