chrome/browser/net/chrome_network_delegate.cc - Issue 1279543002: Support needed to measure user and service traffic in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/chrome_network_delegate.cc

Issue 1279543002: Support needed to measure user and service traffic in Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NewHistogram

Patch Set: Addressing reviewer's comments but the ones related to making component Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/chrome_network_delegate.h ('k') | chrome/browser/net/chrome_network_delegate_unittest.cc » ('j') | components/data_use_measurement/content/data_use_user_data.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/chrome_network_delegate.cc

diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc

index c86931cb3bf8d25602259b320f04ef0ecfb7dc5a..b575a85963ff91b19eebf7d4b22f91d04dcc4ae3 100644

--- a/chrome/browser/net/chrome_network_delegate.cc

+++ b/chrome/browser/net/chrome_network_delegate.cc

@@ -487,6 +487,7 @@ void ChromeNetworkDelegate::OnRawBytesRead(const net::URLRequest& request,

void ChromeNetworkDelegate::OnCompleted(net::URLRequest* request,

bool started) {

+ data_use_measurement_.ReportDataUseUMA(request);

RecordNetworkErrorHistograms(request);

if (started) {

// Only call in for requests that were started, to obey the precondition