components/data_use_measurement/BUILD.gn - Issue 1279543002: Support needed to measure user and service traffic in Chrome.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/data_use_measurement/BUILD.gn

Issue 1279543002: Support needed to measure user and service traffic in Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NewHistogram

Patch Set: Adding sclittle to OWNERs and little fix in ChromeNetworkDelegate test. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/profiles/profile_manager.cc ('K') | « components/data_use_measurement.gypi ('k') | components/data_use_measurement/OWNERS » ('j') | components/data_use_measurement/content/data_use_measurement.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("data_use_measurement_content") {
	blundell 2015/08/31 09:15:40 It's preferred in GN to just put a BUILD.gn file i It's preferred in GN to just put a BUILD.gn file in each of the subdirectories with the target for that subdirectory. amohammadkhan 2015/09/01 04:52:48 Done. Show quoted text On 2015/08/31 09:15:40, blundell wrote: > It's preferred in GN to just put a BUILD.gn file in each of the subdirectories > with the target for that subdirectory. Done.
	6 sources = [

	7 "content/data_use_measurement.cc",

	8 "content/data_use_measurement.h",

	9 ]

	10 deps = [

	11 ":data_use_measurement_core",

	12 "//content/public/browser",

	13 "//net/base",
	blundell 2015/08/31 09:15:40 the //net deps here don't seem to exactly match th the //net deps here don't seem to exactly match the one in gyp. amohammadkhan 2015/09/01 04:52:48 Done. Show quoted text On 2015/08/31 09:15:40, blundell wrote: > the //net deps here don't seem to exactly match the one in gyp. Done.
	14 "//net/url_request",

	15 ]

	16 }

	17

	18 source_set("data_use_measurement_core") {

	19 sources = [

	20 "core/data_use_user_data.cc",

	21 "core/data_use_user_data.h",

	22 ]

	23 deps = [

	24 "//net/base",
	blundell 2015/08/31 09:15:40 the deps here don't match the ones in GYP. the deps here don't match the ones in GYP. amohammadkhan 2015/09/01 04:52:48 Done. Show quoted text On 2015/08/31 09:15:40, blundell wrote: > the deps here don't match the ones in GYP. Done.
	25 ]

	26 }

OLD	NEW