Support needed to measure user and service traffic in Chrome.

net/url_request/url_fetcher_core.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_fetcher_core.h"
 
 #include <stdint.h>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 84 matching lines @@
       was_cancelled_(false),
       stop_on_redirect_(false),
       stopped_on_redirect_(false),
       automatically_retry_on_5xx_(true),
       num_retries_on_5xx_(0),
       max_retries_on_5xx_(0),
       num_retries_on_network_changes_(0),
       max_retries_on_network_changes_(0),
       current_upload_bytes_(-1),
       current_response_bytes_(0),
-      total_response_bytes_(-1) {
+      total_response_bytes_(-1),

[bengr, 2015/08/07 18:00:02]

Why are these initialized to -1 and not 0?

[amohammadkhan, 2015/08/11 22:04:36]

To be distinguishable if they are not touched at all by us, but I think it was
not necessary so I am going to change it to zero.

+      total_downloaded_bytes_(-1),
+      total_sent_bytes_(-1) {
   CHECK(original_url_.is_valid());
 }
 
 void URLFetcherCore::Start() {
   DCHECK(delegate_task_runner_.get());
   DCHECK(request_context_getter_.get()) << "We need an URLRequestContext!";
   if (network_task_runner_.get()) {
     DCHECK_EQ(network_task_runner_,
               request_context_getter_->GetNetworkTaskRunner());
   } else {
@@ skipping 224 matching lines @@
 }
 
 const URLRequestStatus& URLFetcherCore::GetStatus() const {
   return status_;
 }
 
 int URLFetcherCore::GetResponseCode() const {
   return response_code_;
 }
 
+int64 URLFetcherCore::GetBytesSentSize() const {

[bengr, 2015/08/07 18:00:01]

GetTotalBytesSent()

[amohammadkhan, 2015/08/11 22:04:36]

Done.

+  return total_sent_bytes_;
+}
+
+int64 URLFetcherCore::GetBytesReceivedSize() const {

[bengr, 2015/08/07 18:00:02]

GetTotalReceivedBytes()

[amohammadkhan, 2015/08/11 22:04:36]

Done.

+  return total_downloaded_bytes_;

[bengr, 2015/08/07 18:00:02]

total_received_bytes_. In general, please be consistent with names.

[amohammadkhan, 2015/08/11 22:04:36]

At first I had use total_received_bytes. But when I rebased my code after a
while, this name was used by someone else! so I changed the name to
total_downloaded_bytes! I saw it's definition, it might be similar but it's
value is increase in some other function than the function I had used. So I
didn't want to risk and use some variable that I have not experiments on it and
I am not sure about its value so I kept my own variable.

+}
+
 const ResponseCookies& URLFetcherCore::GetCookies() const {
   return cookies_;
 }
 
 void URLFetcherCore::ReceivedContentWasMalformed() {
   DCHECK(delegate_task_runner_->BelongsToCurrentThread());
   if (network_task_runner_.get()) {
     network_task_runner_->PostTask(
         FROM_HERE, base::Bind(&URLFetcherCore::NotifyMalformedContent, this));
   }
@@ skipping 440 matching lines @@
 }
 
 void URLFetcherCore::CancelRequestAndInformDelegate(int result) {
   CancelURLRequest(result);
   delegate_task_runner_->PostTask(
       FROM_HERE,
       base::Bind(&URLFetcherCore::InformDelegateFetchIsComplete, this));
 }
 
 void URLFetcherCore::ReleaseRequest() {
+  if (request_) {
+    total_received_bytes_ = request_->GetTotalReceivedBytes();
+    int request_body_bytes = 0;
+    int request_header_bytes = 0;
+    int total_request_bytes = 0;
+    if (request_->has_upload()) {

[bengr, 2015/08/07 18:00:02]

Remove curly braces.

[amohammadkhan, 2015/08/11 22:04:36]

Done.

+      request_body_bytes = request_->get_upload()->size();
+    }
+    net::HttpRequestHeaders request_headers;
+    if (request_->GetFullRequestHeaders(&request_headers)) {

[bengr, 2015/08/07 18:00:02]

Remove curly braces.

[amohammadkhan, 2015/08/11 22:04:36]

Done.

+      request_header_bytes = request_headers.ToString().length();
+    }
+    total_request_bytes = request_body_bytes + request_header_bytes;
+    total_sent_bytes_ = total_request_bytes;
+  }
+
   request_context_getter_->RemoveObserver(this);
   upload_progress_checker_timer_.reset();
   request_.reset();
   g_registry.Get().RemoveURLFetcherCore(this);
 }
 
 base::TimeTicks URLFetcherCore::GetBackoffReleaseTime() {
   DCHECK(network_task_runner_->BelongsToCurrentThread());
 
   if (!original_url_throttler_entry_.get())
@@ skipping 130 matching lines @@
 }
 
 void URLFetcherCore::AssertHasNoUploadData() const {
   DCHECK(!upload_content_set_);
   DCHECK(upload_content_.empty());
   DCHECK(upload_file_path_.empty());
   DCHECK(upload_stream_factory_.is_null());
 }
 
 }  // namespace net