Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: fpdfsdk/src/fpdfdoc_embeddertest.cpp

Issue 1279493003: Fix some sign comparison warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/formfiller/FFL_ListBox.cpp ('k') | fpdfsdk/src/javascript/Document.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 PDFium Authors. All rights reserved. 1 // Copyright 2015 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "../../public/fpdf_doc.h" 5 #include "../../public/fpdf_doc.h"
6 #include "../../public/fpdfview.h" 6 #include "../../public/fpdfview.h"
7 #include "../../testing/embedder_test.h" 7 #include "../../testing/embedder_test.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 class FPDFDocEmbeddertest : public EmbedderTest {}; 10 class FPDFDocEmbeddertest : public EmbedderTest {};
11 11
12 TEST_F(FPDFDocEmbeddertest, DestGetPageIndex) { 12 TEST_F(FPDFDocEmbeddertest, DestGetPageIndex) {
13 EXPECT_TRUE(OpenDocument("testing/resources/named_dests.pdf")); 13 EXPECT_TRUE(OpenDocument("testing/resources/named_dests.pdf"));
14 14
15 // NULL FPDF_DEST case. 15 // NULL FPDF_DEST case.
16 EXPECT_EQ(0, FPDFDest_GetPageIndex(document(), nullptr)); 16 EXPECT_EQ(0U, FPDFDest_GetPageIndex(document(), nullptr));
17 17
18 // Page number directly in item from Dests NameTree. 18 // Page number directly in item from Dests NameTree.
19 FPDF_DEST dest = FPDF_GetNamedDestByName(document(), "First"); 19 FPDF_DEST dest = FPDF_GetNamedDestByName(document(), "First");
20 EXPECT_NE(nullptr, dest); 20 EXPECT_NE(nullptr, dest);
21 EXPECT_EQ(1, FPDFDest_GetPageIndex(document(), dest)); 21 EXPECT_EQ(1U, FPDFDest_GetPageIndex(document(), dest));
22 22
23 // Page number via object reference in item from Dests NameTree. 23 // Page number via object reference in item from Dests NameTree.
24 dest = FPDF_GetNamedDestByName(document(), "Next"); 24 dest = FPDF_GetNamedDestByName(document(), "Next");
25 EXPECT_NE(nullptr, dest); 25 EXPECT_NE(nullptr, dest);
26 EXPECT_EQ(1, FPDFDest_GetPageIndex(document(), dest)); 26 EXPECT_EQ(1U, FPDFDest_GetPageIndex(document(), dest));
27 27
28 // Page number directly in item from Dests dictionary. 28 // Page number directly in item from Dests dictionary.
29 dest = FPDF_GetNamedDestByName(document(), "FirstAlternate"); 29 dest = FPDF_GetNamedDestByName(document(), "FirstAlternate");
30 EXPECT_NE(nullptr, dest); 30 EXPECT_NE(nullptr, dest);
31 EXPECT_EQ(11, FPDFDest_GetPageIndex(document(), dest)); 31 EXPECT_EQ(11U, FPDFDest_GetPageIndex(document(), dest));
32 32
33 // Invalid object reference in item from Dests NameTree. 33 // Invalid object reference in item from Dests NameTree.
34 dest = FPDF_GetNamedDestByName(document(), "LastAlternate"); 34 dest = FPDF_GetNamedDestByName(document(), "LastAlternate");
35 EXPECT_NE(nullptr, dest); 35 EXPECT_NE(nullptr, dest);
36 EXPECT_EQ(0, FPDFDest_GetPageIndex(document(), dest)); 36 EXPECT_EQ(0U, FPDFDest_GetPageIndex(document(), dest));
37 } 37 }
OLDNEW
« no previous file with comments | « fpdfsdk/src/formfiller/FFL_ListBox.cpp ('k') | fpdfsdk/src/javascript/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698