Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1279483003: Added Signin Utilites (RE-LAND) (Closed)

Created:
5 years, 4 months ago by Sean Kirmani
Modified:
5 years, 4 months ago
Reviewers:
Yaron, jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added Signin Utilites (RE-LAND) Re-Land of https://codereview.chromium.org/1258563005/ - Made Google OS Sign-in Tests FlakyTest - Fixed test account preferences that caused the real Google account sign-in tests to fail previously. BUG= Committed: https://crrev.com/fdfcc1041386b4e8e48c30d3d9463bd84ba5d731 Cr-Commit-Position: refs/heads/master@{#342385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -0 lines) Patch
A chrome/android/javatests/src/org/chromium/chrome/test/util/ChromeSigninUtilsTest.java View 1 chunk +144 lines, -0 lines 0 comments Download
A chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeSigninUtils.java View 1 chunk +229 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sean Kirmani
5 years, 4 months ago (2015-08-07 16:41:42 UTC) #2
jbudorick
lgtm +yfriedman for owners
5 years, 4 months ago (2015-08-07 17:38:39 UTC) #4
Yaron
lgtm In the future it's helpful to upload the original patch as patchset 1 so ...
5 years, 4 months ago (2015-08-07 17:42:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279483003/1
5 years, 4 months ago (2015-08-07 17:43:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 18:17:44 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 18:18:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdfcc1041386b4e8e48c30d3d9463bd84ba5d731
Cr-Commit-Position: refs/heads/master@{#342385}

Powered by Google App Engine
This is Rietveld 408576698