Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Unified Diff: runtime/vm/object.cc

Issue 1279453005: Do not try to patch type objects that are already canonical. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code-review-comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/raw_object_snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 61c605fa1a033f260981345f1d0dcd0d41b8fef5..7357dbdc2578da490e0d4d8a55a56c371f0dd6ec 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -15606,6 +15606,7 @@ RawAbstractType* Type::Canonicalize(GrowableObjectArray* trail) const {
return this->raw();
}
ASSERT(this->Equals(type));
+ ASSERT(type.IsCanonical());
return type.raw();
}
@@ -15627,6 +15628,7 @@ RawAbstractType* Type::Canonicalize(GrowableObjectArray* trail) const {
}
ASSERT(type.IsFinalized());
if (this->Equals(type)) {
+ ASSERT(type.IsCanonical());
return type.raw();
}
index++;
@@ -15655,6 +15657,7 @@ RawAbstractType* Type::Canonicalize(GrowableObjectArray* trail) const {
}
ASSERT(type.IsFinalized());
if (this->Equals(type)) {
+ ASSERT(type.IsCanonical());
return type.raw();
}
index++;
« no previous file with comments | « no previous file | runtime/vm/raw_object_snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698