Issue 1279413002: Remove execute bit from binaries install in the toolchain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1279413002: Remove execute bit from binaries install in the toolchain (Closed)

Created:
5 years, 4 months ago by Sam Clegg

Modified:
5 years, 4 months ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/naclports.git@master

Target Ref:
refs/heads/master

Project:
naclports

Visibility:
Public.

Remove execute bit from binaries install in the toolchain Previously they were being exluded but the xfonts build process requires the fc-cache nexe to be installed in the toolchain. TBR=binji Committed: https://chromium.googlesource.com/external/naclports/+/80c0fe3242838ba9e72bf24345e11f00595bdc45

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -27 lines)			Patch
M	lib/naclports/binary_package.py	View	5 chunks	+17 lines, -23 lines	0 comments	Download
M	lib/naclports/source_package.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/naclports/tests/test_binary_package.py	View	1 chunk	+5 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Sam Clegg

Committed patchset #1 (id:1) manually as 80c0fe3242838ba9e72bf24345e11f00595bdc45 (presubmit successful).

5 years, 4 months ago (2015-08-11 05:37:00 UTC) #1

Message was sent while issue was closed.

lgtm