[Mac] Do not unload base::NativeLibary-ies if they contain ObjC segments.

base/native_library.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

[Mark Mentovai, 2013/03/12 19:19:31]

Fix spelling in CL description:
to
[Mac] Do not unload base::NativeLibrary-ies if they contain ObjC segments.

[Robert Sesek, 2013/03/12 20:02:10]

heh libary

 // Use of this source code is governed by a BSD-style license that can be

[Mark Mentovai, 2013/03/12 19:19:31]

Also in the CL description:
This doesn’t say that fixupSelectorsInMethodList is a crash signature, but it
should.

[Robert Sesek, 2013/03/12 20:02:10]

Oops. Done.

 // found in the LICENSE file.
 
 #ifndef BASE_NATIVE_LIBRARY_H_
 #define BASE_NATIVE_LIBRARY_H_
 
 // This file defines a cross-platform "NativeLibrary" type which represents
 // a loadable module.
 
 #include "base/base_export.h"
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #elif defined(OS_MACOSX)
+#include "base/files/file_path.h"

[Mark Mentovai, 2013/03/12 19:19:31]

Dunno if I’d have bothered making this OS-conditional, although I see why you
did it.

 #import <CoreFoundation/CoreFoundation.h>
 #endif  // OS_*
 
 #include "base/string16.h"
 
 // Macro useful for writing cross-platform function pointers.
 #if defined(OS_WIN) && !defined(CDECL)
 #define CDECL __cdecl
 #else
 #define CDECL
 #endif
 
 namespace base {
 
 class FilePath;
 
 #if defined(OS_WIN)
 typedef HMODULE NativeLibrary;
 #elif defined(OS_MACOSX)
 enum NativeLibraryType {
   BUNDLE,
   DYNAMIC_LIB
 };
 struct NativeLibraryStruct {
   NativeLibraryType type;
   CFBundleRefNum bundle_resource_ref;
+  base::FilePath image_path;
   union {
     CFBundleRef bundle;
     void* dylib;
   };
 };
 typedef NativeLibraryStruct* NativeLibrary;
 #elif defined(OS_POSIX)
 typedef void* NativeLibrary;
 #endif  // OS_*
 
@@ skipping 23 matching lines @@
 
 // Returns the full platform specific name for a native library.
 // For example:
 // "mylib" returns "mylib.dll" on Windows, "libmylib.so" on Linux,
 // "mylib.dylib" on Mac.
 BASE_EXPORT string16 GetNativeLibraryName(const string16& name);
 
 }  // namespace base
 
 #endif  // BASE_NATIVE_LIBRARY_H_