Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 127923002: Provide an Isolate for v8::ObjectTemplate::New. (Closed)

Created:
6 years, 11 months ago by Sven Panne
Modified:
6 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/renderer/extensions/object_backed_native_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/pepper/v8_var_converter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/v8_value_converter_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Sven Panne
6 years, 11 months ago (2014-01-08 09:47:12 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-08 09:53:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/127923002/1
6 years, 11 months ago (2014-01-08 09:59:06 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43764
6 years, 11 months ago (2014-01-08 10:19:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/127923002/1
6 years, 11 months ago (2014-01-08 10:21:57 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43769
6 years, 11 months ago (2014-01-08 10:41:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/127923002/1
6 years, 11 months ago (2014-01-08 11:29:41 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 13:55:34 UTC) #8
Message was sent while issue was closed. 
Change committed as 243555

Powered by Google App Engine
This is Rietveld 408576698