chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm - Issue 12792013: Instant extended: Remove suggest commit on lost focus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

Issue 12792013: Instant extended: Remove suggest commit on lost focus (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h ('k') | chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

index 78d128cc8056b8bb4dd41f590ed43c73a9823f40..feec9ed568e7c7ad5b3d1defb305f79b501209ce 100644

--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

@@ -390,15 +390,6 @@ BOOL ThePasteboardIsTooDamnBig() {

}

- (void)setMarkedText:(id)aString selectedRange:(NSRange)selRange {

- if (![self hasMarkedText]) {

- // Before input methods set composition text in the omnibox, we need to

- // examine whether the autocompletion controller accepts the keyword to

- // avoid committing the current composition text wrongly.

- AutocompleteTextFieldObserver* observer = [self observer];

- if (observer)

- observer->OnStartingIME();

- }

[super setMarkedText:aString selectedRange:selRange];

// Because the OmniboxViewMac class treats marked text as content,