Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Unified Diff: chrome/browser/ui/search/instant_controller.cc

Issue 12792013: Instant extended: Remove suggest commit on lost focus (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address pkasting review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_controller.cc
diff --git a/chrome/browser/ui/search/instant_controller.cc b/chrome/browser/ui/search/instant_controller.cc
index bb81748fc747a535a8bda891efe1f2913398aaec..64d4586261bd1062c1ffbcc3d6dfa838aa6fd176 100644
--- a/chrome/browser/ui/search/instant_controller.cc
+++ b/chrome/browser/ui/search/instant_controller.cc
@@ -1217,20 +1217,6 @@ void InstantController::OmniboxLostFocus(gfx::NativeView view_gaining_focus) {
return;
if (model_.mode().is_default()) {
- // Correct search terms if the user clicked on the committed results page
- // while showing an autocomplete suggestion
- if (UseInstantTabToShowSuggestions() && !last_suggestion_.text.empty() &&
- last_suggestion_.behavior == INSTANT_COMPLETE_NEVER &&
- IsViewInContents(GetViewGainingFocus(view_gaining_focus),
- instant_tab_->contents())) {
- // Commit the omnibox's suggested grey text as if the user had typed it.
- browser_->CommitSuggestedText(true);
-
- // Update the state so that next query from hitting Enter from the
- // omnibox is correct.
- last_omnibox_text_ += last_suggestion_.text;
- last_suggestion_ = InstantSuggestion();
- }
// If the overlay is not showing at all, recreate it if it's stale.
ReloadOverlayIfStale();
MaybeSwitchToRemoteOverlay();

Powered by Google App Engine
This is Rietveld 408576698