chrome/common/extensions/user_script.h - Issue 12792005: Allow extensions on chrome:// URLs, when flag is set and permission is explicitly requested

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/user_script.h

Issue 12792005: Allow extensions on chrome:// URLs, when flag is set and permission is explicitly requested (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add a helper method to UserScript to get the appropriate valid schemes Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/extension.cc ('K') | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/user_script.cc » ('j') | chrome/common/extensions/user_script.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/user_script.h

diff --git a/chrome/common/extensions/user_script.h b/chrome/common/extensions/user_script.h

index 49632e5e8f3e8b6890d96efb1050910d11785f04..4f79c6c16b79aba4b29a0ddecfc4f71a1525dec4 100644

--- a/chrome/common/extensions/user_script.h

+++ b/chrome/common/extensions/user_script.h

@@ -28,7 +28,8 @@ class UserScript {

// The bitmask for valid user script injectable schemes used by URLPattern.

enum {

Matt Perry 2013/03/19 17:49:32 Move this into the .cc file so no one accidentally

aboxhall 2013/03/20 22:04:59 Done.

- kValidUserScriptSchemes = URLPattern::SCHEME_HTTP |

+ kValidUserScriptSchemes = URLPattern::SCHEME_CHROMEUI |

+ URLPattern::SCHEME_HTTP |

URLPattern::SCHEME_HTTPS |

URLPattern::SCHEME_FILE |

URLPattern::SCHEME_FTP

@@ -38,6 +39,8 @@ class UserScript {

// extension.

static bool IsURLUserScript(const GURL& url, const std::string& mime_type);

+ static int ValidUserScriptSchemes(bool canExecuteScriptEverywhere);

Matt Perry 2013/03/19 17:49:32 Comment this.

aboxhall 2013/03/20 22:04:59 Done.

// Locations that user scripts can be run inside the document.

enum RunLocation {

UNDEFINED,

« chrome/common/extensions/extension.cc ('K') | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/user_script.cc » ('j') | chrome/common/extensions/user_script.cc » ('J')