chrome/common/extensions/api/extension_api_unittest.cc - Issue 12792005: Allow extensions on chrome:// URLs, when flag is set and permission is explicitly requested

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_api_unittest.cc

Issue 12792005: Allow extensions on chrome:// URLs, when flag is set and permission is explicitly requested (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove allowed_schemes attribute from url_pattern; go back to re-using valid_schemes Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/api/extension_api_unittest.cc

diff --git a/chrome/common/extensions/api/extension_api_unittest.cc b/chrome/common/extensions/api/extension_api_unittest.cc

index 125085cf06a4afd48ba88860fb000ba3d7b2b0c1..7bad4df9335e90533a321332e7e022e7e8918655 100644

--- a/chrome/common/extensions/api/extension_api_unittest.cc

+++ b/chrome/common/extensions/api/extension_api_unittest.cc

@@ -305,11 +305,11 @@ TEST(ExtensionAPI, URLMatching) {

EXPECT_TRUE(MatchesURL(api.get(), "app", "http://example.com/example.html"));

EXPECT_TRUE(MatchesURL(api.get(), "app", "https://blah.net"));

EXPECT_TRUE(MatchesURL(api.get(), "app", "file://somefile.html"));

+ EXPECT_TRUE(MatchesURL(api.get(), "app", "chrome://flags"));

// But not internal URLs (for chrome-extension:// the app API is injected by

// GetSchemasForExtension).

EXPECT_FALSE(MatchesURL(api.get(), "app", "about:flags"));

- EXPECT_FALSE(MatchesURL(api.get(), "app", "chrome://flags"));

EXPECT_FALSE(MatchesURL(api.get(), "app",

"chrome-extension://fakeextension"));

« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | chrome/common/extensions/extension.cc » ('j') | chrome/common/extensions/extension.cc » ('J')