Allow extensions on chrome:// URLs, when flag is set and permission is explicitly requested

chrome/common/extensions/user_script.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/user_script.h"
 
 #include "base/pickle.h"
 #include "base/string_util.h"
 
 namespace {
@@ skipping 110 matching lines @@
        glob != globs.end(); ++glob) {
     pickle->WriteString(*glob);
   }
 }
 
 void UserScript::PickleURLPatternSet(::Pickle* pickle,
                                      const URLPatternSet& pattern_list) const {
   pickle->WriteUInt64(pattern_list.patterns().size());
   for (URLPatternSet::const_iterator pattern = pattern_list.begin();
        pattern != pattern_list.end(); ++pattern) {
+    pickle->WriteString(pattern->GetAsString());
     pickle->WriteInt(pattern->valid_schemes());
-    pickle->WriteString(pattern->GetAsString());
   }
 }
 
 void UserScript::PickleScripts(::Pickle* pickle,
                                const FileList& scripts) const {
   pickle->WriteUInt64(scripts.size());
   for (FileList::const_iterator file = scripts.begin();
        file != scripts.end(); ++file) {
     file->Pickle(pickle);
   }
@@ skipping 32 matching lines @@
 }
 
 void UserScript::UnpickleURLPatternSet(const ::Pickle& pickle,
                                        PickleIterator* iter,
                                        URLPatternSet* pattern_list) {
   uint64 num_patterns = 0;
   CHECK(pickle.ReadUInt64(iter, &num_patterns));
 
   pattern_list->ClearPatterns();
   for (uint64 i = 0; i < num_patterns; ++i) {
+    std::string pattern_str;
+    URLPattern pattern(kValidUserScriptSchemes);
+    CHECK(pickle.ReadString(iter, &pattern_str));
+
+    URLPattern::ParseResult result = pattern.Parse(pattern_str);
+    CHECK(URLPattern::PARSE_SUCCESS == result) <<
+        URLPattern::GetParseResultString(result) << " " << pattern_str.c_str();
+
     int valid_schemes;
     CHECK(pickle.ReadInt(iter, &valid_schemes));
-    std::string pattern_str;
-    URLPattern pattern(valid_schemes);
-    CHECK(pickle.ReadString(iter, &pattern_str));
-
-    // We remove the file scheme if it's not actually allowed (see Extension::
-    // LoadUserScriptHelper), but we need it temporarily while loading the
-    // pattern so that it's valid.
-    bool had_file_scheme = (valid_schemes & URLPattern::SCHEME_FILE) != 0;
-    if (!had_file_scheme)
-      pattern.SetValidSchemes(valid_schemes | URLPattern::SCHEME_FILE);
-    CHECK(URLPattern::PARSE_SUCCESS == pattern.Parse(pattern_str));
-    if (!had_file_scheme)
-      pattern.SetValidSchemes(valid_schemes);
-
+    pattern.SetValidSchemes(valid_schemes);
     pattern_list->AddPattern(pattern);
   }
 }
 
 void UserScript::UnpickleScripts(const ::Pickle& pickle, PickleIterator* iter,
                                  FileList* scripts) {
   uint64 num_files = 0;
   CHECK(pickle.ReadUInt64(iter, &num_files));
   scripts->clear();
   for (uint64 i = 0; i < num_files; ++i) {
     File file;
     file.Unpickle(pickle, iter);
     scripts->push_back(file);
   }
 }
 
 }  // namespace extensions