Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1279133006: Removed unused mojo_nacl code and GYP targets. (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed unused mojo_nacl code and GYP targets. There are subtle generated dependency issues breaking several bots. The code is upstream in the Mojo repo at this point and we have no need for the GYP targets in the foreseeable future. BUG=519643 TBR=jam@chromium.org Committed: https://crrev.com/30011cdf506921f51db7113b54803b886ab928f3 Cr-Commit-Position: refs/heads/master@{#342920}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rm -rf mojo/nacl #

Patch Set 3 : - -l #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1695 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -8 lines 0 comments Download
M build/gn_migration.gypi View 3 chunks +0 lines, -19 lines 0 comments Download
D mojo/mojo_nacl.gyp View 1 chunk +0 lines, -113 lines 0 comments Download
D mojo/mojo_nacl_untrusted.gyp View 1 chunk +0 lines, -84 lines 0 comments Download
D mojo/nacl/BUILD.gn View 1 1 chunk +0 lines, -105 lines 0 comments Download
D mojo/nacl/DEPS View 1 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/nacl/README.md View 1 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/nacl/generator/generate_nacl_bindings.py View 1 1 chunk +0 lines, -507 lines 0 comments Download
D mojo/nacl/generator/interface.py View 1 1 chunk +0 lines, -122 lines 0 comments Download
D mojo/nacl/generator/interface_dsl.py View 1 1 chunk +0 lines, -146 lines 0 comments Download
D mojo/nacl/generator/libmojo.cc.tmpl View 1 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/nacl/generator/mojo_irt.c.tmpl View 1 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/nacl/generator/mojo_irt.h.tmpl View 1 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/nacl/generator/mojo_syscall.cc.tmpl View 1 1 chunk +0 lines, -111 lines 0 comments Download
D mojo/nacl/irt_entry_mojo.c View 1 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/nacl/mojo_syscall.h View 1 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/nacl/mojo_syscall_internal.h View 1 1 chunk +0 lines, -175 lines 0 comments Download
D mojo/nacl/monacl_sel_main.h View 1 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/nacl/monacl_sel_main.cc View 1 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/nacl/monacl_shell.cc View 1 1 chunk +0 lines, -28 lines 0 comments Download
M ppapi/nacl_irt/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/native_client/native_client.gyp View 1 2 6 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Ken Rockot(use gerrit already)
PS1 is the build changes, PS2 is just wiping out mojo/nacl please take a look. ...
5 years, 4 months ago (2015-08-11 21:04:39 UTC) #2
Nick Bray (chromium)
https://codereview.chromium.org/1279133006/diff/1/ppapi/native_client/native_client.gyp File ppapi/native_client/native_client.gyp (left): https://codereview.chromium.org/1279133006/diff/1/ppapi/native_client/native_client.gyp#oldcode247 ppapi/native_client/native_client.gyp:247: '>(tc_lib_dir_irt_mips)/libmojo_irt.a', Delete this for each arch. "mojo" should appear ...
5 years, 4 months ago (2015-08-11 21:06:43 UTC) #3
Nico
rs-lgtm for my stuff
5 years, 4 months ago (2015-08-11 21:07:22 UTC) #4
Ken Rockot(use gerrit already)
https://codereview.chromium.org/1279133006/diff/1/ppapi/native_client/native_client.gyp File ppapi/native_client/native_client.gyp (left): https://codereview.chromium.org/1279133006/diff/1/ppapi/native_client/native_client.gyp#oldcode247 ppapi/native_client/native_client.gyp:247: '>(tc_lib_dir_irt_mips)/libmojo_irt.a', On 2015/08/11 21:06:43, Nick Bray (chromium) wrote: > ...
5 years, 4 months ago (2015-08-11 21:19:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279133006/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279133006/30001
5 years, 4 months ago (2015-08-11 21:19:49 UTC) #8
Nick Bray (chromium)
LGTM
5 years, 4 months ago (2015-08-11 21:20:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279133006/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279133006/30001
5 years, 4 months ago (2015-08-11 21:20:55 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:30001)
5 years, 4 months ago (2015-08-11 22:28:41 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 22:29:25 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/30011cdf506921f51db7113b54803b886ab928f3
Cr-Commit-Position: refs/heads/master@{#342920}

Powered by Google App Engine
This is Rietveld 408576698