Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1279133003: mojo: Merge upstream https://github.com/domokit/mojo/commit/4bbba19b4043e57ed1bd2b9bd799729bc2342b84 (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M third_party/mojo/src/mojo/public/cpp/bindings/lib/map_data_internal.h View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Nico
5 years, 4 months ago (2015-08-07 22:16:32 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 4 months ago (2015-08-07 22:18:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279133003/1
5 years, 4 months ago (2015-08-07 22:19:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/88345)
5 years, 4 months ago (2015-08-07 23:24:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279133003/1
5 years, 4 months ago (2015-08-07 23:56:11 UTC) #9
Nico
Committed patchset #1 (id:1) to pending queue manually as ac2c22e9a9d5fb219a7bb6b0ff283a88f75a17d7 (presubmit successful).
5 years, 4 months ago (2015-08-08 01:26:50 UTC) #10
Nico
rockot, it looks like you lost this in your recent mojo roll. I'll reland it, ...
5 years, 3 months ago (2015-08-24 18:46:06 UTC) #11
Nico
Committed patchset #1 (id:1) manually as dbe9b61b079a21f25d9b8b4b98ba032cc9e2767a (presubmit successful).
5 years, 3 months ago (2015-08-24 18:49:35 UTC) #12
Ken Rockot(use gerrit already)
5 years, 3 months ago (2015-08-24 19:02:30 UTC) #13
Message was sent while issue was closed.
Best way is to roll more frequently so we can avoid one-off patches like
this. Even with infrequent rolls this wouldn't normally happen, but I
decided not to roll all the way up to ToT due to the complexity of doing so
after such a long period. Sorry for the trouble and thanks for re-landing!

On Mon, Aug 24, 2015 at 11:46 AM, <thakis@chromium.org> wrote:

> rockot, it looks like you lost this in your recent mojo roll. I'll reland
> it,
> but is there some way to make sure that changes like this don't get lost?
>
> https://codereview.chromium.org/1279133003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698