SkPDF: allow PDF module to be disabled in DM and SampleApp

SkPDF: allow PDF module to be disabled in DM and SampleApp

To disable PDF:

    GYP_DEFINES='skia_pdf=0' bin/sync-and-gyp
    ninja -C out/Debug dm SampleApp

When disabled, SkDocument::CreatePDF() always returns NULL.

Committed: https://skia.googlesource.com/skia/+/8ee06f21a27bbffaf613a312c6f24bbbb21c650a

[hal.canary, 2015-08-10 22:10:11]

halcanary@google.com changed reviewers:
+ tomhudson@google.com

[hal.canary, 2015-08-10 22:10:11]

PTAL

[reed1, 2015-08-11 13:46:50]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-08-11 13:46:51]

The gpu team seems to have a similar idea, to allow clients to build w/o the
gpu. Their build flag is the opposite sense as yours

#if SK_SUPPORT_GPU

Can we agree on a uniform pattern for these?

[hal.canary, 2015-08-11 14:05:26]

Patchset #2 (id:20001) has been deleted

[hal.canary, 2015-08-11 14:06:08]

On 2015/08/11 13:46:51, reed1 wrote:
> The gpu team seems to have a similar idea, to allow clients to build w/o the
> gpu. Their build flag is the opposite sense as yours
> 
> #if SK_SUPPORT_GPU
> 
> Can we agree on a uniform pattern for these?

done

[reed1, 2015-08-11 15:41:04]

lgtm

Lets consider some follow-up work as well:

- work with Eric to create a builder-bot to test this config
- look for any files (e.g. SkFlate) that could be moved out of core if they are
exclusively needed by PDF
- consider if there are glob ways to exclude entire files like some of these
tests:
   - name suffix
   - sub dirs inside tests/
   - other

https://codereview.chromium.org/1279123007/diff/40001/samplecode/SampleApp.cpp
File samplecode/SampleApp.cpp (right):

https://codereview.chromium.org/1279123007/diff/40001/samplecode/SampleApp.cp...
samplecode/SampleApp.cpp:1174: #if SK_SUPPORT_PDF
Why are we guarding here? Do we not gracefully fail w/ no guards?

[hal.canary, 2015-08-11 17:22:04]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-08-11 17:22:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1279123007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1279123007/40001

[commit-bot: I haz the power, 2015-08-11 17:30:16]

Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/8ee06f21a27bbffaf613a312c6f24bbbb21c650a