chrome/browser/extensions/external_registry_loader_win.cc - Issue 1279123004: Replace ToLower calls to the new format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_registry_loader_win.cc

Issue 1279123004: Replace ToLower calls to the new format (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/external_registry_loader_win.cc

diff --git a/chrome/browser/extensions/external_registry_loader_win.cc b/chrome/browser/extensions/external_registry_loader_win.cc

index a1c289315575b57ee67974c2152b2adfd11a9e1c..0b5a67f83687c838b7723790af6f0953dc435e9f 100644

--- a/chrome/browser/extensions/external_registry_loader_win.cc

+++ b/chrome/browser/extensions/external_registry_loader_win.cc

@@ -98,8 +98,7 @@ void ExternalRegistryLoader::LoadOnFileThread() {

continue;

}

- std::string id = base::UTF16ToASCII(*it);

- base::StringToLowerASCII(&id);

+ std::string id = base::ToLowerASCII(base::UTF16ToASCII(*it));

if (!crx_file::id_util::IdIsValid(id)) {

LOG(ERROR) << "Invalid id value " << id

<< " for key " << key_path << ".";