Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1279093002: Reland of Add channel-specific product logo to chrome://help (Closed)

Created:
5 years, 4 months ago by Evan Stade
Modified:
5 years, 4 months ago
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add channel-specific product logo to chrome://help (patchset #1 id:1 of https://codereview.chromium.org/1280033002/ ) Reason for revert: Official build bots were all happy with the change --- suspect the issue was a local config problem (such as not updating src-internal). Original issue's description: > Revert of Add channel-specific product logo to chrome://help (patchset #3 id:40001 of https://codereview.chromium.org/1269383005/ ) > > Reason for revert: > Reverting due to missing files. See comments in cl: > https://codereview.chromium.org/1269383005/ > > Original issue's description: > > Add channel-specific product logo to chrome://help > > > > BUG=511000 > > > > Committed: https://crrev.com/9836302ea4ffb887ce6ffa597c1ee5484d2f1091 > > Cr-Commit-Position: refs/heads/master@{#342183} > > TBR=oshima@chromium.org,dbeam@chromium.org,estade@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=511000 > > Committed: https://crrev.com/abd20f67987aaa47bb47e61288ec92b4ab761521 > Cr-Commit-Position: refs/heads/master@{#342324} TBR=oshima@chromium.org,dbeam@chromium.org,tommi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=511000 Committed: https://crrev.com/43556713374f9ef0b5a5254f0a4116fe5b1c4eb3 Cr-Commit-Position: refs/heads/master@{#342369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M chrome/app/theme/theme_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/help/help_content.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/help/help_ui.cc View 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
Created Reland of Add channel-specific product logo to chrome://help
5 years, 4 months ago (2015-08-07 17:20:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279093002/1
5 years, 4 months ago (2015-08-07 17:20:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 17:21:46 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 17:22:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43556713374f9ef0b5a5254f0a4116fe5b1c4eb3
Cr-Commit-Position: refs/heads/master@{#342369}

Powered by Google App Engine
This is Rietveld 408576698