Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: Source/bindings/scripts/idl_parser.pm

Issue 127903002: Empty reflected attributes and string literals in extended attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Allow string literals for extended attributes Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/bindings/tests/idls/TestObject.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/idl_parser.pm
diff --git a/Source/bindings/scripts/idl_parser.pm b/Source/bindings/scripts/idl_parser.pm
index 67ea502b7d1f2f82a2b9bd6c9e64d07023d0ed88..1876c404fcc9eb033b3895bf6c6b80105a5c3220 100644
--- a/Source/bindings/scripts/idl_parser.pm
+++ b/Source/bindings/scripts/idl_parser.pm
@@ -1620,6 +1620,10 @@ sub parseExtendedAttributeRest2
my $token = $self->getToken();
return $token->value();
}
+ if ($next->type() == StringToken) {
haraken 2014/01/09 10:19:05 Would you add a comment that this is a syntax exte
sof 2014/01/09 11:13:17 certainly; added. I also added productions to the
+ my $token = $self->getToken();
+ return $self->parseExtendedAttributeRest3($self->unquoteString($token->value()));
+ }
$self->assertUnexpectedToken($next->value(), __LINE__);
}
« no previous file with comments | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/bindings/tests/idls/TestObject.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698