Empty reflected attributes and string literals in extended attributes.

Source/bindings/scripts/code_generator_v8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 6257 matching lines @@
         }
     }
     return @checks;
 }
 
 sub GenerateReflectOnlyCheck
 {
     my $extendedAttributes = shift;
     my $indent = shift;
 
-    my $knownValueString = $extendedAttributes->{"ReflectOnly"};
-    my @knownValues = split(quotemeta("|"), $knownValueString);
+    my $attributeValueList = $extendedAttributes->{"ReflectOnly"};
+    my @knownValues = split(quotemeta("|"), $attributeValueList);
 
     my $missingValueDefault = $extendedAttributes->{"ReflectMissing"};
     if ($missingValueDefault) {
         if (!grep { $_ eq $missingValueDefault } @knownValues) {
-            die "Missing attribute value is not a known value " . $missingValueDefault;
+            die "The [ReflectMissing] attribute value '${missingValueDefault}' is not a known value ";
         }
         $missingValueDefault = "resultValue = \"${missingValueDefault}\"";
     } else {
         $missingValueDefault = "";
     }
 
     my $invalidValueDefault = $extendedAttributes->{"ReflectInvalid"};
     if ($invalidValueDefault) {
         if (!grep { $_ eq $invalidValueDefault } @knownValues) {
-            die "Invalid attribute value is not a known value " . $invalidValueDefault;
+            die "The [ReflectInvalid] attribute value '${invalidValueDefault}' is not a known value ";
         }
-        $invalidValueDefault = "\"${invalidValueDefault}\"";
+        $invalidValueDefault = "resultValue = \"${invalidValueDefault}\"";
     } else {
-        $invalidValueDefault = "\"\"";
+        $invalidValueDefault = "resultValue = \"\"";
+    }
+
+    my @normalizeAttributeCode = ();
+
+    # Attributes without a value (div empty-attribute>) can be
+    # separately reflected to some value.
+
+    my $isAttributeValueMissing = "resultValue.isEmpty()";
+    my $emptyValueDefault = $extendedAttributes->{"ReflectEmpty"};
+    if ($emptyValueDefault) {
+        if (!grep { $_ eq $emptyValueDefault } @knownValues) {
+            die "The [ReflectEmpty] attribute value '${emptyValueDefault}' is not a known value ";
+        }
+        $isAttributeValueMissing = "resultValue.isNull()";
+        push(@normalizeAttributeCode, "${indent}} else if (resultValue.isEmpty()) {");
+        push(@normalizeAttributeCode, "${indent}    resultValue = \"$emptyValueDefault\";");
     }
 
     # Attribute is limited to only known values: check that the attribute
     # value is one of those..and if not, set it to the empty string.
     # ( http://www.whatwg.org/specs/web-apps/current-work/#limited-to-only-known-values )
     #
-    my @normalizeAttributeCode = ();
-    my $code = "";
     foreach my $knownValue (@knownValues) {
         push(@normalizeAttributeCode, "${indent}} else if (equalIgnoringCase(resultValue, \"$knownValue\")) {");
         push(@normalizeAttributeCode, "${indent}    resultValue = \"$knownValue\";");
     }
     my $normalizeAttributeValue = join("\n", @normalizeAttributeCode);
-    $code .= <<END;
-${indent}if (resultValue.isEmpty()) {
+    my $code .= <<END;
+${indent}if ($isAttributeValueMissing) {
 ${indent}    $missingValueDefault;
 ${normalizeAttributeValue}
 ${indent}} else {
-${indent}    resultValue = $invalidValueDefault;
+${indent}    $invalidValueDefault;
 ${indent}}
 END
         return "${code}";
 }
 
 sub ExtendedAttributeContains
 {
     my $extendedAttributeValue = shift;
     return 0 unless $extendedAttributeValue;
     my $keyword = shift;
@@ skipping 58 matching lines @@
         if ($parameter->type eq "SerializedScriptValue") {
             return 1;
         } elsif (IsIntegerType($parameter->type)) {
             return 1;
         }
     }
     return 0;
 }
 
 1;