Empty reflected attributes and string literals in extended attributes.

Source/bindings/scripts/unstable/blink_idl_parser.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 287 matching lines @@
                               |"""
         if len(p) > 3:
             p[0] = ListFromConcat(p[2], p[3])
 
     # [b51] Add ExtendedAttributeIdentAndOrIdent
     def p_ExtendedAttribute(self, p):
         """ExtendedAttribute : ExtendedAttributeNoArgs
                              | ExtendedAttributeArgList
                              | ExtendedAttributeIdent
                              | ExtendedAttributeIdentList
+                             | ExtendedAttributeStringLiteralList
                              | ExtendedAttributeNamedArgList"""
         p[0] = p[1]
 
     # [59]
     # FIXME: Upstream UnionType
     def p_UnionType(self, p):
         """UnionType : '(' UnionMemberType OR UnionMemberType UnionMemberTypes ')'"""
         members = ListFromConcat(p[2], p[4], p[5])
         p[0] = self.BuildProduction('UnionType', p, 1, members)
 
@@ skipping 46 matching lines @@
 
     # [b76.3] A|B|C
     def p_IdentOrList(self, p):
         """IdentOrList : identifier '|' IdentOrList
                        | identifier"""
         if len(p) > 3:
             p[0] = p[1] + p[2] + p[3]
         else:
             p[0] = p[1]
 
+    # Blink extension: Add support for compound Extended Attribute values over string literals ("A"|"B")
+    def p_ExtendedAttributeStringLiteralList(self, p):
+        """ExtendedAttributeStringLiteralList : identifier '=' StringLiteralOrList"""
+        value = self.BuildAttribute('VALUE', p[3])
+        p[0] = self.BuildNamed('ExtAttribute', p, 1, value)
+
+    # Blink extension: one or more string literals. The values aren't propagated as literals,
+    # but their by their value only.
+    def p_StringLiteralOrList(self, p):
+        """StringLiteralOrList : StringLiteral '|' StringLiteralOrList
+                               | StringLiteral"""
+        def unwrap_string(ls):
+            """

[Nils Barth (inactive), 2014/01/09 11:24:27]

One-line docstring please:
http://www.python.org/dev/peps/pep-0257/#one-line-docstrings

This docstring can be one line:
"""Reach in..."""

BTW,
Generally multiline are:
"""Foo

Bar
Zork
"""
(without the leading newline)

Ref:
http://www.python.org/dev/peps/pep-0257/

[sof, 2014/01/09 11:42:35]

thanks, updated.

+            Reach in and grab the string literal's "NAME".
+            """
+            return ls[1].value
+
+        if len(p) > 3:
+            p[0] = unwrap_string(p[1]) + p[2] + p[3]
+        else:
+            p[0] = unwrap_string(p[1])
+
     def __dir__(self):
         # Remove REMOVED_RULES from listing so yacc doesn't parse them
         # FIXME: Upstream
         keys = set(self.__dict__.keys() + dir(self.__class__))
         for rule in REMOVED_RULES:
             production_name = 'p_' + rule
             if production_name in keys:
                 keys.remove(production_name)
         return list(keys)
 
@@ skipping 11 matching lines @@
         self._parse_errors = 0
         self._parse_warnings = 0
         self._last_error_msg = None
         self._last_error_lineno = 0
         self._last_error_pos = 0
 
 
 # If run by itself, attempt to build the parser
 if __name__ == '__main__':
     parser = BlinkIDLParser()