Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: tools/gyp/v8.gyp

Issue 12790011: Rename target-specific binaries built for host. (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Wrap lines where possible Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index 2d6eaf9d0f220d2a4402c97335dd084dc0c87b27..a14f91a2f8db7a4b511b5a4de8f63b215085ea69 100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -43,13 +43,16 @@
# The dependency on v8_base should come from a transitive
# dependency however the Android toolchain requires libv8_base.a
# to appear before libv8_snapshot.a so it's listed explicitly.
- 'dependencies': ['v8_base', 'v8_snapshot'],
+ 'dependencies': ['v8_base.<(v8_target_arch)', 'v8_snapshot'],
},
{
# The dependency on v8_base should come from a transitive
# dependency however the Android toolchain requires libv8_base.a
# to appear before libv8_snapshot.a so it's listed explicitly.
- 'dependencies': ['v8_base', 'v8_nosnapshot'],
+ 'dependencies': [
+ 'v8_base.<(v8_target_arch)',
+ 'v8_nosnapshot.<(v8_target_arch)',
+ ],
}],
['component=="shared_library"', {
'type': '<(component)',
@@ -105,10 +108,13 @@
'conditions': [
['want_separate_host_toolset==1', {
'toolsets': ['host', 'target'],
- 'dependencies': ['mksnapshot#host', 'js2c#host'],
+ 'dependencies': [
+ 'mksnapshot.<(v8_target_arch)#host',
+ 'js2c#host',
+ ],
}, {
'toolsets': ['target'],
- 'dependencies': ['mksnapshot', 'js2c'],
+ 'dependencies': ['mksnapshot.<(v8_target_arch)', 'js2c'],
}],
['component=="shared_library"', {
'defines': [
@@ -124,7 +130,7 @@
}],
],
'dependencies': [
- 'v8_base',
+ 'v8_base.<(v8_target_arch)',
],
'include_dirs+': [
'../../src',
@@ -138,7 +144,7 @@
{
'action_name': 'run_mksnapshot',
'inputs': [
- '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mksnapshot<(EXECUTABLE_SUFFIX)',
+ '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mksnapshot.<(v8_target_arch)<(EXECUTABLE_SUFFIX)',
],
'outputs': [
'<(INTERMEDIATE_DIR)/snapshot.cc',
@@ -192,10 +198,10 @@
],
},
{
- 'target_name': 'v8_nosnapshot',
+ 'target_name': 'v8_nosnapshot.<(v8_target_arch)',
'type': 'static_library',
'dependencies': [
- 'v8_base',
+ 'v8_base.<(v8_target_arch)',
],
'include_dirs+': [
'../../src',
@@ -222,7 +228,7 @@
]
},
{
- 'target_name': 'v8_base',
+ 'target_name': 'v8_base.<(v8_target_arch)',
'type': 'static_library',
'variables': {
'optimize': 'max',
@@ -868,11 +874,11 @@
]
},
{
- 'target_name': 'mksnapshot',
+ 'target_name': 'mksnapshot.<(v8_target_arch)',
'type': 'executable',
'dependencies': [
- 'v8_base',
- 'v8_nosnapshot',
+ 'v8_base.<(v8_target_arch)',
+ 'v8_nosnapshot.<(v8_target_arch)',
],
'include_dirs+': [
'../../src',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698