Issue 12790004: Made AdjustAmountOfExternalAllocatedMemory an instance method of Isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12790004: Made AdjustAmountOfExternalAllocatedMemory an instance method of Isolate (Closed)

Created:
7 years, 9 months ago by Sven Panne

Modified:
7 years, 9 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Made AdjustAmountOfExternalAllocatedMemory an instance method of Isolate BUG=v8:2487 Committed: http://code.google.com/p/v8/source/detail?r=13933

Patch Set 2 : Feedback #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -21 lines)			Patch
M	include/v8.h	View	1	2 chunks	+17 lines, -14 lines	0 comments	Download
M	src/api.cc	View		1 chunk	+9 lines, -2 lines	0 comments	Download
M	src/d8.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm with nit https://codereview.chromium.org/12790004/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/12790004/diff/1/include/v8.h#newcode3016 include/v8.h:3016: * collections more often than otherwise ...

7 years, 9 months ago (2013-03-13 12:57:33 UTC) #2

Sven Panne

Feedback addressed, landing... https://codereview.chromium.org/12790004/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/12790004/diff/1/include/v8.h#newcode3016 include/v8.h:3016: * collections more often than otherwise ...

7 years, 9 months ago (2013-03-13 13:14:13 UTC) #3

Sven Panne

7 years, 9 months ago (2013-03-13 13:15:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r13933 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12790004: Made AdjustAmountOfExternalAllocatedMemory an instance method of Isolate (Closed)

Description

Patch Set 1 #

Patch Set 2 : Feedback #

Messages