Issue 1278973004: Remove outdated versions of StartsWith and EndsWith from string_util.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1278973004: Remove outdated versions of StartsWith and EndsWith from string_util.cc (Closed)

Created:
5 years, 4 months ago by Andrey Kraynov

Modified:
5 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews, jshin+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove outdated versions of StartsWith and EndsWith from string_util.cc It seems that old versions of StartsWith and EndsWith are unused and can be removed completely. R=brettw BUG=none Committed: https://crrev.com/df3bc178a2487a0c2ad4c5b06934f11f155eb441 Cr-Commit-Position: refs/heads/master@{#342838}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -36 lines)			Patch
	M	base/strings/string_util.cc	View		2 chunks	+1 line, -36 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Andrey Kraynov

Hi! Could you take a look please at this CL? Thanks in advance!

5 years, 4 months ago (2015-08-11 09:50:23 UTC) #1

brettw

Ha, I removed everything else but forgot the actual code. LGTM

5 years, 4 months ago (2015-08-11 15:37:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278973004/1

5 years, 4 months ago (2015-08-11 16:11:37 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-11 17:33:04 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/df3bc178a2487a0c2ad4c5b06934f11f155eb441
Cr-Commit-Position: refs/heads/master@{#342838}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages