base/debug/proc_maps_linux.cc - Issue 1278973003: Revert of Update SplitString calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/proc_maps_linux.cc

Issue 1278973003: Revert of Update SplitString calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/proc_maps_linux.cc

diff --git a/base/debug/proc_maps_linux.cc b/base/debug/proc_maps_linux.cc

index 8c8965b8f1519b0e5c8e3b2bc47c7e510b262d17..4c1aedf00329757a09d7e5d548e4063a4cb440dd 100644

--- a/base/debug/proc_maps_linux.cc

+++ b/base/debug/proc_maps_linux.cc

@@ -96,8 +96,8 @@

// This isn't async safe nor terribly efficient, but it doesn't need to be at

// this point in time.

- std::vector<std::string> lines = SplitString(

- input, "\n", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

+ std::vector<std::string> lines;

+ SplitString(input, '\n', &lines);

for (size_t i = 0; i < lines.size(); ++i) {

// Due to splitting on '\n' the last line should be empty.

« no previous file with comments | « base/command_line.cc ('k') | base/process/internal_linux.cc » ('j') | no next file with comments »