Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: gpu/config/gpu_control_list.cc

Issue 1278973003: Revert of Update SplitString calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/config/gpu_info_collector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/config/gpu_control_list.cc
diff --git a/gpu/config/gpu_control_list.cc b/gpu/config/gpu_control_list.cc
index 2e44e3db50c60adc12f694465910fa7a493f517e..1fbf0b6f5aa2427243a9150757b800afe5fe79b5 100644
--- a/gpu/config/gpu_control_list.cc
+++ b/gpu/config/gpu_control_list.cc
@@ -25,9 +25,7 @@
char splitter,
std::vector<std::string>* version) {
DCHECK(version);
- *version = base::SplitString(
- version_string, std::string(1, splitter),
- base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+ base::SplitString(version_string, splitter, version);
if (version->size() == 0)
return false;
// If the splitter is '-', we assume it's a date with format "mm-dd-yyyy";
@@ -1030,8 +1028,8 @@
if (gl_version_info_.get() == NULL && gl_type_ == kGLTypeNone)
return false;
- std::vector<std::string> segments = base::SplitString(
- gl_version, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+ std::vector<std::string> segments;
+ base::SplitString(gl_version, ' ', &segments);
std::string number;
GLType gl_type = kGLTypeNone;
if (segments.size() > 2 &&
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/config/gpu_info_collector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698