gpu/config/gpu_info_collector_android.cc - Issue 1278973003: Revert of Update SplitString calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/config/gpu_info_collector_android.cc

Issue 1278973003: Revert of Update SplitString calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/config/gpu_info_collector_android.cc

diff --git a/gpu/config/gpu_info_collector_android.cc b/gpu/config/gpu_info_collector_android.cc

index c6d9b19456a6176714fded5252f1405cb6697e1d..93da6a937231e69bcf4e93f39c518470abe7f1e6 100644

--- a/gpu/config/gpu_info_collector_android.cc

+++ b/gpu/config/gpu_info_collector_android.cc

@@ -34,8 +34,8 @@

sub_string = version_string.substr(begin, end - begin);

else

sub_string = version_string.substr(begin);

- std::vector<std::string> pieces = base::SplitString(

- sub_string, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

+ std::vector<std::string> pieces;

+ base::SplitString(sub_string, '.', &pieces);

if (pieces.size() >= 2)

return std::make_pair(pieces[0] + "." + pieces[1], end);

else

« no previous file with comments | « gpu/config/gpu_info_collector.cc ('k') | gpu/config/gpu_info_collector_linux.cc » ('j') | no next file with comments »