media/formats/mp4/track_run_iterator_unittest.cc - Issue 1278973003: Revert of Update SplitString calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mp4/track_run_iterator_unittest.cc

Issue 1278973003: Revert of Update SplitString calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/mp4/track_run_iterator_unittest.cc

diff --git a/media/formats/mp4/track_run_iterator_unittest.cc b/media/formats/mp4/track_run_iterator_unittest.cc

index f9dde7204f1c169dd313739820a0743b906c2283..6bfab113cf954f16b3e26587e9d3bf79e335d18d 100644

--- a/media/formats/mp4/track_run_iterator_unittest.cc

+++ b/media/formats/mp4/track_run_iterator_unittest.cc

@@ -146,8 +146,8 @@

// ON - SampleDependsOnOthers & IsNonSyncSample

// NS - SampleDependsOnNoOthers & IsSyncSample

// NN - SampleDependsOnNoOthers & IsNonSyncSample

- std::vector<std::string> flags_data = base::SplitString(

- sample_info, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

+ std::vector<std::string> flags_data;

+ base::SplitString(sample_info, ' ', &flags_data);

if (flags_data.size() == 1u) {

// Simulates the first_sample_flags_present set scenario,

« no previous file with comments | « media/formats/mp4/avc_unittest.cc ('k') | media/renderers/video_renderer_impl_unittest.cc » ('j') | no next file with comments »