content/browser/service_worker/service_worker_database.cc - Issue 1278973003: Revert of Update SplitString calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_database.cc

Issue 1278973003: Revert of Update SplitString calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_database.cc

diff --git a/content/browser/service_worker/service_worker_database.cc b/content/browser/service_worker/service_worker_database.cc

index b79894ea803f780814b0ea13c17f2e17424ff021..ddfcb742fea20c0e6e0d6f35dea7f8dad8c7b600 100644

--- a/content/browser/service_worker/service_worker_database.cc

+++ b/content/browser/service_worker/service_worker_database.cc

@@ -1214,9 +1214,8 @@

if (!RemovePrefix(itr->key().ToString(), kRegKeyPrefix, &key))

break;

- std::vector<std::string> parts =

- base::SplitString(key, std::string(1, kKeySeparator),

- base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);

+ std::vector<std::string> parts;

+ base::SplitStringDontTrim(key, kKeySeparator, &parts);

if (parts.size() != 2) {

status = STATUS_ERROR_CORRUPTED;

HandleReadResult(FROM_HERE, status);