Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: google_apis/gaia/gaia_auth_util.cc

Issue 1278973003: Revert of Update SplitString calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « google_apis/gaia/gaia_auth_fetcher.cc ('k') | gpu/command_buffer/service/feature_info.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "google_apis/gaia/gaia_auth_util.h" 5 #include "google_apis/gaia/gaia_auth_util.h"
6 6
7 #include "base/json/json_reader.h" 7 #include "base/json/json_reader.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/strings/string_split.h" 9 #include "base/strings/string_split.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
11 #include "base/values.h" 11 #include "base/values.h"
12 #include "google_apis/gaia/gaia_urls.h" 12 #include "google_apis/gaia/gaia_urls.h"
13 #include "url/gurl.h" 13 #include "url/gurl.h"
14 14
15 namespace gaia { 15 namespace gaia {
16 16
17 namespace { 17 namespace {
18 18
19 const char kGmailDomain[] = "gmail.com"; 19 const char kGmailDomain[] = "gmail.com";
20 const char kGooglemailDomain[] = "googlemail.com"; 20 const char kGooglemailDomain[] = "googlemail.com";
21 21
22 std::string CanonicalizeEmailImpl(const std::string& email_address, 22 std::string CanonicalizeEmailImpl(const std::string& email_address,
23 bool change_googlemail_to_gmail) { 23 bool change_googlemail_to_gmail) {
24 std::vector<std::string> parts = base::SplitString( 24 std::vector<std::string> parts;
25 email_address, "@", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL); 25 char at = '@';
26 base::SplitString(email_address, at, &parts);
26 if (parts.size() != 2U) { 27 if (parts.size() != 2U) {
27 NOTREACHED() << "expecting exactly one @, but got " 28 NOTREACHED() << "expecting exactly one @, but got "
28 << (parts.empty() ? 0 : parts.size() - 1) 29 << (parts.empty() ? 0 : parts.size() - 1)
29 << " : " << email_address; 30 << " : " << email_address;
30 } else { 31 } else {
31 if (change_googlemail_to_gmail && parts[1] == kGooglemailDomain) 32 if (change_googlemail_to_gmail && parts[1] == kGooglemailDomain)
32 parts[1] = kGmailDomain; 33 parts[1] = kGmailDomain;
33 34
34 if (parts[1] == kGmailDomain) // only strip '.' for gmail accounts. 35 if (parts[1] == kGmailDomain) // only strip '.' for gmail accounts.
35 base::RemoveChars(parts[0], ".", &parts[0]); 36 base::RemoveChars(parts[0], ".", &parts[0]);
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 accounts->push_back(listed_account); 157 accounts->push_back(listed_account);
157 } 158 }
158 } 159 }
159 } 160 }
160 } 161 }
161 162
162 return true; 163 return true;
163 } 164 }
164 165
165 } // namespace gaia 166 } // namespace gaia
OLDNEW
« no previous file with comments | « google_apis/gaia/gaia_auth_fetcher.cc ('k') | gpu/command_buffer/service/feature_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698