Revert of Update SplitString calls to new form

extensions/common/manifest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/manifest.h"
 
 #include "base/basictypes.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/strings/string_split.h"
@@ skipping 222 matching lines @@
 
 int Manifest::GetManifestVersion() const {
   // Platform apps were launched after manifest version 2 was the preferred
   // version, so they default to that.
   int manifest_version = type_ == TYPE_PLATFORM_APP ? 2 : 1;
   value_->GetInteger(keys::kManifestVersion, &manifest_version);
   return manifest_version;
 }
 
 bool Manifest::CanAccessPath(const std::string& path) const {
+  std::vector<std::string> components;
+  base::SplitString(path, '.', &components);
   std::string key;
-  for (const base::StringPiece& component : base::SplitStringPiece(
-           path, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) {
-    component.AppendToString(&key);
+  for (size_t i = 0; i < components.size(); ++i) {
+    key += components[i];
     if (!CanAccessKey(key))
       return false;
     key += '.';
   }
   return true;
 }
 
 bool Manifest::CanAccessKey(const std::string& key) const {
   Feature* feature = FeatureProvider::GetManifestFeatures()->GetFeature(key);
   if (!feature)
     return true;
 
   return feature->IsAvailableToManifest(
                       extension_id_, type_, location_, GetManifestVersion())
       .is_available();
 }
 
 }  // namespace extensions