Revert of Update SplitString calls to new form

base/test/launcher/test_launcher.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/launcher/test_launcher.h"
 
 #if defined(OS_POSIX)
 #include <fcntl.h>
 #endif
 
@@ skipping 543 matching lines @@
     print_snippet = (result.status != TestResult::TEST_SUCCESS);
   } else if (print_test_stdio == "always") {
     print_snippet = true;
   } else if (print_test_stdio == "never") {
     print_snippet = false;
   } else {
     LOG(WARNING) << "Invalid value of " << switches::kTestLauncherPrintTestStdio
                  << ": " << print_test_stdio;
   }
   if (print_snippet) {
-    std::vector<std::string> snippet_lines = SplitString(
-        result.output_snippet, "\n", base::KEEP_WHITESPACE,
-        base::SPLIT_WANT_ALL);
+    std::vector<std::string> snippet_lines;
+    SplitStringDontTrim(result.output_snippet, '\n', &snippet_lines);
     if (snippet_lines.size() > kOutputSnippetLinesLimit) {
       size_t truncated_size = snippet_lines.size() - kOutputSnippetLinesLimit;
       snippet_lines.erase(
           snippet_lines.begin(),
           snippet_lines.begin() + truncated_size);
       snippet_lines.insert(snippet_lines.begin(), "<truncated>");
     }
     fprintf(stdout, "%s", base::JoinString(snippet_lines, "\n").c_str());
     fflush(stdout);
   }
@@ skipping 208 matching lines @@
 
   if (command_line->HasSwitch(switches::kTestLauncherFilterFile)) {
     std::string filter;
     if (!ReadFileToString(
             command_line->GetSwitchValuePath(switches::kTestLauncherFilterFile),
             &filter)) {
       LOG(ERROR) << "Failed to read the filter file.";
       return false;
     }
 
-    std::vector<std::string> filter_lines = SplitString(
-        filter, "\n", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+    std::vector<std::string> filter_lines;
+    SplitString(filter, '\n', &filter_lines);
     for (size_t i = 0; i < filter_lines.size(); i++) {
       if (filter_lines[i].empty())
         continue;
 
       if (filter_lines[i][0] == '-')
         negative_test_filter_.push_back(filter_lines[i].substr(1));
       else
         positive_test_filter_.push_back(filter_lines[i]);
     }
   } else {
     // Split --gtest_filter at '-', if there is one, to separate into
     // positive filter and negative filter portions.
     std::string filter = command_line->GetSwitchValueASCII(kGTestFilterFlag);
     size_t dash_pos = filter.find('-');
     if (dash_pos == std::string::npos) {
-      positive_test_filter_ = SplitString(
-          filter, ":", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+      SplitString(filter, ':', &positive_test_filter_);
     } else {
       // Everything up to the dash.
-      positive_test_filter_ = SplitString(
-          filter.substr(0, dash_pos), ":", base::TRIM_WHITESPACE,
-          base::SPLIT_WANT_ALL);
+      SplitString(filter.substr(0, dash_pos), ':', &positive_test_filter_);
 
       // Everything after the dash.
-      negative_test_filter_ = SplitString(
-          filter.substr(dash_pos + 1), ":", base::TRIM_WHITESPACE,
-          base::SPLIT_WANT_ALL);
+      SplitString(filter.substr(dash_pos + 1), ':', &negative_test_filter_);
     }
   }
 
   if (!launcher_delegate_->GetTests(&tests_)) {
     LOG(ERROR) << "Failed to get list of tests.";
     return false;
   }
 
   if (!results_tracker_.Init(*command_line)) {
     LOG(ERROR) << "Failed to initialize test results tracker.";
@@ skipping 245 matching lines @@
   }
 
   std::string snippet(full_output.substr(run_pos));
   if (end_pos != std::string::npos)
     snippet = full_output.substr(run_pos, end_pos - run_pos);
 
   return snippet;
 }
 
 }  // namespace base