DescriptionRevert of [Android] Make enhanced bookmark editing UI more straightforward. (patchset #8 id:140001 of https://codereview.chromium.org/1230313009/ )
Reason for revert:
http://crbug.com/519368
Original issue's description:
> [Android] Make enhanced bookmark editing UI more straightforward.
>
> - We didn't save when a dialog is dismissed by tapping outside on
> tablet, which can be also confusing as there is no save UI concept.
> So save onPause always.
>
> - User should know when we won't save what user typed if it fails
> validation. But blocking dialog exit is too invasive, and sometimes
> we don't have a control (tapping outside on tablet.) So show warning
> as user types.
>
> BUG=510253
>
> Committed: https://crrev.com/5886fc8beb1ae5714f25a8bb1c76a42bfe88272c
> Cr-Commit-Position: refs/heads/master@{#342719}
TBR=ianwen@chromium.org,newt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=510253
BUT=519368
Committed: https://crrev.com/e4e239b82468281bd98acd8dbf3c76c205d180a2
Cr-Commit-Position: refs/heads/master@{#342826}
Patch Set 1 #
Created: 5 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|