Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1278963004: Revert of [Android] Make enhanced bookmark editing UI more straightforward. (Closed)

Created:
5 years, 4 months ago by Kibeom Kim (inactive)
Modified:
5 years, 4 months ago
Reviewers:
Ian Wen, newt (away)
CC:
chromium-reviews, ianwen+watch_chromium.org, newt (away)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Make enhanced bookmark editing UI more straightforward. (patchset #8 id:140001 of https://codereview.chromium.org/1230313009/ ) Reason for revert: http://crbug.com/519368 Original issue's description: > [Android] Make enhanced bookmark editing UI more straightforward. > > - We didn't save when a dialog is dismissed by tapping outside on > tablet, which can be also confusing as there is no save UI concept. > So save onPause always. > > - User should know when we won't save what user typed if it fails > validation. But blocking dialog exit is too invasive, and sometimes > we don't have a control (tapping outside on tablet.) So show warning > as user types. > > BUG=510253 > > Committed: https://crrev.com/5886fc8beb1ae5714f25a8bb1c76a42bfe88272c > Cr-Commit-Position: refs/heads/master@{#342719} TBR=ianwen@chromium.org,newt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510253 BUT=519368 Committed: https://crrev.com/e4e239b82468281bd98acd8dbf3c76c205d180a2 Cr-Commit-Position: refs/heads/master@{#342826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -64 lines) Patch
M chrome/android/java/res/layout/eb_edit.xml View 2 chunks +13 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkAddEditFolderActivity.java View 3 chunks +27 lines, -19 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java View 6 chunks +17 lines, -26 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/EmptyAlertEditText.java View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kibeom Kim (inactive)
Created Revert of [Android] Make enhanced bookmark editing UI more straightforward.
5 years, 4 months ago (2015-08-11 16:05:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278963004/1
5 years, 4 months ago (2015-08-11 16:05:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 16:06:14 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 16:06:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4e239b82468281bd98acd8dbf3c76c205d180a2
Cr-Commit-Position: refs/heads/master@{#342826}

Powered by Google App Engine
This is Rietveld 408576698