runtime/vm/globals.h - Issue 1278943002: Attempt to fix inline assembly on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/globals.h

Issue 1278943002: Attempt to fix inline assembly on Windows (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/globals.h

diff --git a/runtime/vm/globals.h b/runtime/vm/globals.h

index 49d710d611cdf2529c31ce86d4831dd94bd59774..72fae8ee0644cb1e2751669ccc22e4b3aa7bb7f9 100644

--- a/runtime/vm/globals.h

+++ b/runtime/vm/globals.h

@@ -94,9 +94,9 @@ static const uword kZapUninitializedWord = 0xabababababababab;

#if defined(TARGET_OS_WINDOWS)

#if defined(HOST_ARCH_IA32)

-#define COPY_FP_REGISTER(fp) __asm { movl fp, ebp }; // NOLINT

+#define COPY_FP_REGISTER(fp) __asm { mov fp, ebp }; // NOLINT

#elif defined(HOST_ARCH_X64)

-#define COPY_FP_REGISTER(fp) __asm { movq fp, rbp }; // NOLINT

+#define COPY_FP_REGISTER(fp) __asm { mov fp, rbp }; // NOLINT

#else

#error Unknown host architecture.

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »