Issue 127893002: generator output should be relative to depth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 127893002: generator output should be relative to depth. (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 11 months ago

Reviewers:
Jói

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

generator output should be relative to depth. Currently, it's a strange mix between depth, the filename, and generator output that happens to work if depth is . BUG=none TEST=test/generator-output/gyptest-depth.py R=joi@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1830

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -2 lines)			Patch
	M	pylib/gyp/generator/make.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download
	A	test/generator-output/gyptest-depth.py	View	1	1 chunk	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

6 years, 11 months ago (2014-01-08 10:10:15 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r1830 (presubmit successful).

Expand Messages | Collapse Messages