[win] Change app launcher profile indicator to be a menu.

ui/app_list/app_list_menu.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_APP_LIST_APP_LIST_MENU_H_
+#define UI_APP_LIST_APP_LIST_MENU_H_
+
+#include "ui/base/models/simple_menu_model.h"
+
+namespace app_list {
+
+class AppListViewDelegate;
+
+class AppListMenu : ui::SimpleMenuModel::Delegate {

[tapted, 2013/03/20 07:44:20]

Should probably have a class comment

[tapted, 2013/03/20 07:44:20]

Should this be AppListMenuModel ? It also seems common to use multiple
inheritance. E.g.

class CornerSelectionMenuModel : public ui::SimpleMenuModel,
                                 public ui::SimpleMenuModel::Delegate {

+ a ~dozen others

[benwells, 2013/03/20 08:43:34]

As I don't need to override anything in SimpleMenuModel this feels better.

[benwells, 2013/03/20 08:43:34]

Done.

+ public:
+  enum AppListMenuCommands {
+    CURRENT_USER,

[tapted, 2013/03/20 07:44:20]

It seems common to start these enums from 1 (small sample size, from `git grep
-A5 'enum.*MenuCommands'`

[benwells, 2013/03/20 08:43:34]

Done.

+    SHOW_SETTINGS,
+    SHOW_FEEDBACK,
+  };
+
+  explicit AppListMenu(AppListViewDelegate* delegate);
+  virtual ~AppListMenu() {}

[tapted, 2013/03/20 07:44:20]

non-trivial destructor to .cc?

[benwells, 2013/03/20 08:43:34]

Done.

+
+ protected:

[tapted, 2013/03/20 07:44:20]

private from here?

(I think non-private data members are suggested only for test harnesses (ref:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Access_Control )

[benwells, 2013/03/20 08:43:34]

Done.

+  ui::SimpleMenuModel menu_model_;
+  AppListViewDelegate* delegate_;
+
+ private:
+  void InitMenu();
+
+  virtual bool IsCommandIdChecked(int command_id) const OVERRIDE;
+  virtual bool IsCommandIdEnabled(int command_id) const OVERRIDE;
+  virtual bool GetAcceleratorForCommandId(
+      int command_id,
+      ui::Accelerator* accelerator) OVERRIDE;
+  virtual void ExecuteCommand(int command_id, int event_flags) OVERRIDE;
+
+  DISALLOW_COPY_AND_ASSIGN(AppListMenu);
+};
+
+}  // namespace app_list
+
+#endif  // UI_APP_LIST_APP_LIST_MENU_H_