Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 12789006: base/prefs: Remove the public/ directory and move the files to //base/prefs. (Closed)

Created:
7 years, 9 months ago by tfarina
Modified:
7 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, nkostylev+watch_chromium.org, jam, rpetterson, ahutter, yoshiki+watch_chromium.org, gideonwald, dbeam+watch-autofill_chromium.org, rginda+watch_chromium.org, stuartmorgan+watch_chromium.org, dmazzoni+watch_chromium.org, browser-components-watch_chromium.org, ajwong+watch_chromium.org, markusheintz_, benjhayden+dwatch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, cbentzel+watch_chromium.org, benquan, ben+watch_chromium.org, aboxhall+watch_chromium.org, Ilya Sherman, achuith+watch_chromium.org, dyu1, apatrick_chromium, dominich, dhollowa+watch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, tim (not reviewing), pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, rdsmith+dwatch_chromium.org, derat+watch_chromium.org, Raghu Simha, rouslan+spellwatch_chromium.org, yuzo+watch_chromium.org, samarth+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, Albert Bodenhamer, haitaol1, ctguil+watch_chromium.org, Jered, zork+watch_chromium.org, akalin, hashimoto+watch_chromium.org, sreeram, Raman Kakilate, sail+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, eroman, David Black, Dane Wallinga, dtseng+watch_chromium.org, estade+watch_chromium.org, melevin, mmenke, davemoore+watch_chromium.org
Visibility:
Public.

Description

base/prefs: Remove the public/ directory and move the files to //base/prefs. BUG=155525 R=joi@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189513

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -1428 lines) Patch
M base/base.gyp View 3 chunks +6 lines, -6 lines 0 comments Download
M base/prefs/mock_pref_change_callback.h View 1 chunk +1 line, -1 line 0 comments Download
A + base/prefs/pref_change_registrar.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/prefs/pref_change_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/prefs/pref_change_registrar_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/prefs/pref_member.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/prefs/pref_member.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/prefs/pref_member_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D base/prefs/public/pref_change_registrar.h View 1 chunk +0 lines, -80 lines 0 comments Download
D base/prefs/public/pref_change_registrar.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D base/prefs/public/pref_change_registrar_unittest.cc View 1 chunk +0 lines, -200 lines 0 comments Download
D base/prefs/public/pref_member.h View 1 chunk +0 lines, -354 lines 0 comments Download
D base/prefs/public/pref_member.cc View 1 chunk +0 lines, -224 lines 0 comments Download
D base/prefs/public/pref_member_unittest.cc View 1 chunk +0 lines, -321 lines 0 comments Download
M chrome/browser/app_controller_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_mode_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/audio/audio_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_sync_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/session_length_limiter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/cookie_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_prefs.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/save_package_file_picker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/managed_mode_private/managed_mode_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/preference/preference_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/component_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_policy_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/install_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gpu/gpu_mode_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/io_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_mode.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_service.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_http_user_agent_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/http_server_properties_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/net_error_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/net_pref_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/ssl_config_service_manager_pref.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/balloon_notification_ui_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_ui_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_prefs.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_status_pref_setter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_core.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/url_blacklist_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/scoped_user_pref_update_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/gaia_info_update_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_tab_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/speech/chrome_speech_recognition_preferences.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_prefs.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_errors_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/alternate_error_tab_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/event_rewriter_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_models.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gesture_prefs_observer_factory_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/global_menu_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_login_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/keyboard_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/pointer_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/core_options_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/font_settings_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/managed_user_settings_handler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/media_galleries_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/password_manager_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/startup_pages_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/zoom/zoom_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autocomplete_history_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
./tools/git/move_source_file.py made this super easy :) Please, have a look. Thanks,
7 years, 9 months ago (2013-03-20 00:33:32 UTC) #1
Jói
LGTM, thanks. On Wed, Mar 20, 2013 at 12:33 AM, <tfarina@chromium.org> wrote: > Reviewers: Jói, ...
7 years, 9 months ago (2013-03-20 00:38:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12789006/4001
7 years, 9 months ago (2013-03-20 22:01:13 UTC) #3
tfarina
TBRing Darin for the master OWNER.
7 years, 9 months ago (2013-03-20 22:01:35 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=125273
7 years, 9 months ago (2013-03-21 01:09:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12789006/4001
7 years, 9 months ago (2013-03-21 01:16:41 UTC) #6
tfarina
Committed patchset #2 manually as r189513 (presubmit successful).
7 years, 9 months ago (2013-03-21 03:33:38 UTC) #7
darin (slow to review)
7 years, 9 months ago (2013-03-21 05:19:57 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698