Issue 12789003: Android WebView: fix linking host binaries on mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12789003: Android WebView: fix linking host binaries on mac. (Closed)

Created:
7 years, 9 months ago by Torne

Modified:
7 years, 9 months ago

Reviewers:
benm (inactive)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android WebView: fix linking host binaries on mac. WebView needs to build on mac hosts; filter out flags not supported by mac's linker. These are not important for host binaries which aren't shipped. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187830

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	build/common.gypi	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Torne

7 years, 9 months ago (2013-03-13 11:13:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r187830 (presubmit successful).

Expand Messages | Collapse Messages