Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1278873007: [runtime] Remove premature optimization from ToPrimitive. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Jarin, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove premature optimization from ToPrimitive. The !IS_SPEC_OBJECT(x) check implies both IS_STRING(x) and IS_SIMD_VALUE(x), and generates shorter/better code. So we can safely remove the redundant checks. R=rossberg@chromium.org Committed: https://crrev.com/0c674828dc2bdefd6f111d278408a938686edcfd Cr-Commit-Position: refs/heads/master@{#30081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/runtime.js View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 4 months ago (2015-08-08 18:45:56 UTC) #1
Benedikt Meurer
Hey Andreas, Here's an easy one that I discovered while looking into how we can ...
5 years, 4 months ago (2015-08-08 18:46:53 UTC) #2
Jarin
lgtm
5 years, 4 months ago (2015-08-10 05:27:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278873007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278873007/1
5 years, 4 months ago (2015-08-10 05:27:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 06:07:25 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 06:07:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c674828dc2bdefd6f111d278408a938686edcfd
Cr-Commit-Position: refs/heads/master@{#30081}

Powered by Google App Engine
This is Rietveld 408576698