Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1278873005: Fix nextKeyView: loop in HttpAuth.xib. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ipc_rename_proxy_channel
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix nextKeyView: loop in HttpAuth.xib. The nextKeyView: loop somehow got lost during the xib migration. BUG=516191 Committed: https://crrev.com/b73a94c3c7b65a9b7e1ae597bff0ce386d6a1e43 Cr-Commit-Position: refs/heads/master@{#342478}

Patch Set 1 #

Patch Set 2 : Fix chrome's auth sheet. #

Patch Set 3 : #

Patch Set 4 : Remove dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/app/nibs/HttpAuthLoginSheet.xib View 1 3 chunks +7 lines, -1 line 0 comments Download
M content/shell/app/English.lproj/HttpAuth.xib View 1 2 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
erikchen
rsesek: Looking for a review of chrome/app/nibs/HttpAuthLoginSheet.xib. avi: Looking for a review of content/
5 years, 4 months ago (2015-08-07 18:15:40 UTC) #2
Robert Sesek
Wonder why this broke… lossy conversion? LGTM
5 years, 4 months ago (2015-08-07 20:03:39 UTC) #3
Avi (use Gerrit)
lgtm
5 years, 4 months ago (2015-08-07 20:18:19 UTC) #4
erikchen
On 2015/08/07 20:18:19, Avi wrote: > lgtm The broken xibs have a Referencing Outlet called ...
5 years, 4 months ago (2015-08-07 20:32:48 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 1270683002 Patch 100001). Please resolve the dependency and ...
5 years, 4 months ago (2015-08-07 20:33:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278873005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278873005/60001
5 years, 4 months ago (2015-08-07 22:12:37 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-07 23:34:37 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 23:35:14 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b73a94c3c7b65a9b7e1ae597bff0ce386d6a1e43
Cr-Commit-Position: refs/heads/master@{#342478}

Powered by Google App Engine
This is Rietveld 408576698